podman-remote start#2917
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Apr 17, 2019
Merged
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
Member
|
LGTM |
Member
|
LGTM |
Member
Author
|
@giuseppe any ideas what might be going on here? |
Member
|
I think that's resource limits for the container being nonzero... |
Collaborator
|
☔ The latest upstream changes (presumably #2830) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
Collaborator
|
☔ The latest upstream changes (presumably #2949) made this pull request unmergeable. Please resolve the merge conflicts. |
baude
force-pushed
the
remotestart
branch
2 times, most recently
from
f5b6f76 to
db737f9
Compare
enable the ability to start containers from the remote-client. also, enable start integration tests for remote testing. Signed-off-by: baude <bbaude@redhat.com>
Member
|
Reiterating LGTM once tests go green. |
Member
|
/lgtm |
This was referenced Apr 17, 2019
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable the ability to start containers from the remote-client. also,
enable start integration tests for remote testing.
Signed-off-by: baude bbaude@redhat.com